Fix test_floating.py test to call sys.exit #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, the test should fail now (good to verify). Then I believe this patch will fix: diff --git a/cunumeric/_ufunc/ufunc.py b/cunumeric/_ufunc/ufunc.py
index 47ae475b..c6d2a327 100644
--- a/cunumeric/_ufunc/ufunc.py
+++ b/cunumeric/_ufunc/ufunc.py
@@ -264,7 +264,7 @@ class ufunc:
raise TypeError("return arrays must be of ArrayType")
def _prepare_operands(
- self, *args: Any, out: Union[ndarray, None], where: bool = True
+ self, *args: Any, out: Union[ndarray, tuple[ndarray, ...], None], where: bool = True
) -> tuple[
Sequence[ndarray],
Sequence[Union[ndarray, None]],
@@ -295,6 +295,8 @@ class ufunc:
computed_out = (None,) * self.nout
elif not isinstance(out, tuple):
computed_out = (out,)
+ else:
+ computed_out = out
outputs = tuple(
self._maybe_convert_output_to_cunumeric_ndarray(arr)
@@ -469,7 +471,7 @@ class multiout_unary_ufunc(ufunc):
def __call__(
self,
*args: Any,
- out: Union[ndarray, None] = None,
+ out: Union[ndarray, tuple[ndarray, ...], None] = None,
where: bool = True,
casting: CastingKind = "same_kind",
order: str = "K", |
|
First we'll get a CI failure, and then we'll fix the issues that cause test failures. |
|
I've created #434 regarding developing a linter of some sort for this. |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this test is not calling
sys.exit, the test failures are not correctly registered. In this PR we fix the test and the failing test cases.